failj/ntspi-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(vikon): remove hardcoded module IDs and use config everywhere

Browse Source
This commit is contained in:
F4ilji
2026-07-05 11:40:02 +05:00
parent 8cf195efb0
commit 0a5f99e6ae
6 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Containers/VikonIntegration/Actions/UpdateCoreAction.php
+6 -5
View File
@@ -37,8 +37,9 @@ class UpdateCoreAction
private function downloadCore(int $moduleId, string $modulePath, string $tempPath, string $accessToken): void
{
if ($moduleId === 2) {
$this->initAbiturModule($modulePath, $accessToken);
$moduleConfig = $this->modulesConfig[$moduleId] ?? [];
if (!empty($moduleConfig['init_only'])) {
$this->initModuleFromApi($moduleId, $modulePath, $accessToken);
return;
}
@@ -229,13 +230,13 @@ class UpdateCoreAction
return $response->json()['directories'] ?? [];
}
private function initAbiturModule(string $modulePath, string $accessToken): void
private function initModuleFromApi(int $moduleId, string $modulePath, string $accessToken): void
{
$response = $this->http->getWithToken('pull_updates/generateEmptyModuleCore/2', $accessToken);
$response = $this->http->getWithToken("pull_updates/generateEmptyModuleCore/{$moduleId}", $accessToken);
$body = $response->json();
if (!isset($body['success']) || $body['success'] !== true) {
throw new \RuntimeException('ABITUR init failed: ' . ($body['message'] ?? 'Unknown'));
throw new \RuntimeException("Module init failed for module {$moduleId}: " . ($body['message'] ?? 'Unknown'));
}
File::makeDirectory($modulePath, 0755, true, true);