refactor ClientDepartmentController and ClientFacultyController; replace caching logic with action classes for department and faculty retrieval, enhancing code clarity and maintainability

This commit is contained in:
F4ilji
2025-07-20 18:02:14 +05:00
parent 5179f45ef9
commit 3cac482409
11 changed files with 259 additions and 144 deletions
@@ -0,0 +1,28 @@
<?php
namespace App\Containers\InstituteStructure\Tasks;
use App\Containers\InstituteStructure\Models\Department;
use App\Containers\InstituteStructure\UI\WEB\Transformers\DepartmentPreviewResource;
use App\Ship\Enums\CacheKeys;
use Illuminate\Http\Resources\Json\AnonymousResourceCollection;
use Illuminate\Support\Facades\Cache;
class GetActiveDepartmentsByFacultyIdTask
{
public function run(int $facultyId): AnonymousResourceCollection
{
return Cache::remember(
CacheKeys::DEPARTMENTS_PREFIX->value . 'active_' . $facultyId,
now()->addDay(),
function () use ($facultyId) {
return DepartmentPreviewResource::collection(
Department::query()
->where('is_active', true)
->where('faculty_id', $facultyId)
->get()
);
}
);
}
}
@@ -0,0 +1,27 @@
<?php
namespace App\Containers\InstituteStructure\Tasks;
use App\Containers\InstituteStructure\Models\Faculty;
use App\Containers\InstituteStructure\UI\WEB\Transformers\FacultyPreviewResource;
use App\Ship\Enums\CacheKeys;
use Illuminate\Http\Resources\Json\AnonymousResourceCollection;
use Illuminate\Support\Facades\Cache;
class GetActiveFacultiesTask
{
public function run(): AnonymousResourceCollection
{
return Cache::remember(
CacheKeys::FACULTIES_PREFIX->value . 'active_list',
now()->addDay(), // Кешируем на 1 день
function () {
return FacultyPreviewResource::collection(
Faculty::query()
->where('is_active', true)
->get()
);
}
);
}
}
@@ -0,0 +1,34 @@
<?php
namespace App\Containers\InstituteStructure\Tasks;
use App\Containers\InstituteStructure\Models\Department;
use App\Ship\Enums\CacheKeys;
use Illuminate\Support\Facades\Cache;
class GetDepartmentBySlugTask
{
public function run(string $departmentSlug, string $cacheKey): Department
{
return Cache::remember(
CacheKeys::DEPARTMENT_PREFIX->value . $cacheKey,
now()->addDay(),
function () use ($departmentSlug) {
return Department::query()
->where('slug', $departmentSlug)
->where('is_active', true)
->with([
'faculty',
'workers' => fn ($query) => $query->orderBy('sort', 'asc'),
'teachers' => fn ($query) => $query->orderBy('sort', 'asc'),
'programs' => fn ($query) => $query->orderBy('sort', 'asc'),
'workers.userDetail',
'teachers.userDetail',
'programs.directionStudy',
'seo'
])
->firstOrFail();
}
);
}
}
@@ -0,0 +1,23 @@
<?php
namespace App\Containers\InstituteStructure\Tasks;
use App\Containers\InstituteStructure\Models\Faculty;
use App\Ship\Enums\CacheKeys;
use Illuminate\Support\Facades\Cache;
class GetFacultyBySlugOnlyTask
{
public function run(string $facultySlug): Faculty
{
return Cache::remember(
CacheKeys::FACULTY_PREFIX->value . $facultySlug,
now()->addDay(),
function () use ($facultySlug) {
return Faculty::query()
->where('slug', $facultySlug)
->firstOrFail();
}
);
}
}
@@ -0,0 +1,28 @@
<?php
namespace App\Containers\InstituteStructure\Tasks;
use App\Containers\InstituteStructure\Models\Faculty;
use App\Ship\Enums\CacheKeys;
use Illuminate\Support\Facades\Cache;
class GetFacultyBySlugTask
{
public function run(string $slug): Faculty
{
return Cache::remember(
CacheKeys::FACULTY_PREFIX->value . $slug,
now()->addDay(),
function () use ($slug) {
return Faculty::where('slug', $slug)
->where('is_active', true)
->with(['departments.faculty',
'workers' => fn ($query) => $query->orderBy('sort', 'asc'),
'workers.userDetail',
'seo'
])
->firstOrFail();
}
);
}
}
@@ -0,0 +1,16 @@
<?php
namespace App\Containers\InstituteStructure\Tasks;
use Illuminate\Database\Eloquent\Collection;
class GroupProgramsByDirectionTask
{
public function run(Collection $programs): Collection
{
// Группируем программы по имени направления
return $programs->groupBy(function ($program) {
return $program->directionStudy->code . " " . $program->directionStudy->name; // Используем имя направления как ключ
});
}
}