failj/ntspi-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(vikon): check HTTP status instead of JSON field for part generation check

Browse Source
This commit is contained in:
F4ilji
2026-07-05 10:55:37 +05:00
parent 3d9982e5be
commit af1fb094d2
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Containers/VikonIntegration/Actions/UpdatePartAction.php
+4 -4
View File
@@ -55,15 +55,15 @@ class UpdatePartAction
throw new \RuntimeException("Part generation failed: {$error}"); throw new \RuntimeException("Part generation failed: {$error}");
} }
// Step 3: Check result // Step 3: Check result (API returns HTTP 200 on success, no JSON body needed)
$checkResponse = $this->http->getWithToken( $checkResponse = $this->http->getWithToken(
"pull_updates/checkPartGenerationByNewCoreResultJson?operation_identity={$operationIdentity}&part={$part}", "pull_updates/checkPartGenerationByNewCoreResultJson?operation_identity={$operationIdentity}&part={$part}",
$accessToken $accessToken
); );
$checkBody = $checkResponse->json();
if (empty($checkBody['success'])) { if ($checkResponse->failed()) {
throw new \RuntimeException('Part not ready: ' . ($checkBody['message'] ?? 'Unknown')); $body = $checkResponse->json([]);
throw new \RuntimeException('Part not ready: ' . ($body['message'] ?? 'HTTP ' . $checkResponse->status()));
} }
// Step 4: Download ZIP // Step 4: Download ZIP
app/Containers/VikonIntegration/Tests/Unit/UpdatePartActionTest.php
+3 -1
View File
@@ -85,10 +85,12 @@ class UpdatePartActionTest extends TestCase
->with('op-abc-123', 'token') ->with('op-abc-123', 'token')
->andReturn(['status' => 'completed']); ->andReturn(['status' => 'completed']);
$checkResponse = Mockery::mock(Response::class);
$checkResponse->shouldReceive('failed')->once()->andReturn(false);
$http->shouldReceive('getWithToken') $http->shouldReceive('getWithToken')
->once() ->once()
->with('pull_updates/checkPartGenerationByNewCoreResultJson?operation_identity=op-abc-123&part=common', 'token') ->with('pull_updates/checkPartGenerationByNewCoreResultJson?operation_identity=op-abc-123&part=common', 'token')
->andReturn($this->mockResponse(['success' => true])); ->andReturn($checkResponse);
// Create a minimal ZIP // Create a minimal ZIP
$tempZipDir = $this->tempDir . '/zip_source'; $tempZipDir = $this->tempDir . '/zip_source';