failj/ntspi-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(vikon): add file type validation and temp cleanup in UpdatePartAction

Browse Source
This commit is contained in:
F4ilji
2026-07-05 03:01:12 +05:00
parent 059705d60d
commit e8e36156e9
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Containers/VikonIntegration/Actions/UpdatePartAction.php
+14 -5
View File
@@ -87,13 +87,22 @@ class UpdatePartAction
$zip->close(); $zip->close();
File::delete($zipFile); File::delete($zipFile);
// Validate extracted file types
$blocked = $this->fs->validateFileTypes($tempPath);
if (!empty($blocked)) {
File::deleteDirectory($tempPath);
throw new \RuntimeException('Blocked files in ZIP: ' . implode(', ', $blocked));
}
$modulePath = $this->basePath . '/' . $config['path']; $modulePath = $this->basePath . '/' . $config['path'];
// Step 5: Apply try {
$syncedCount = $this->applyPart($part, $tempPath, $modulePath, $moduleId, $config); // Step 5: Apply
$syncedCount = $this->applyPart($part, $tempPath, $modulePath, $moduleId, $config);
// Step 6: Clean temp } finally {
File::deleteDirectory($tempPath); // Step 6: Clean temp (always runs, even on exception)
File::deleteDirectory($tempPath);
}
Log::info('Vikon: part update complete', ['module' => $moduleId, 'part' => $part, 'synced' => $syncedCount]); Log::info('Vikon: part update complete', ['module' => $moduleId, 'part' => $part, 'synced' => $syncedCount]);